[#17] Add Eclipse Dash license check for C# bindings#18
Open
patdhlk wants to merge 5 commits intoeclipse-iceoryx:mainfrom
Open
[#17] Add Eclipse Dash license check for C# bindings#18patdhlk wants to merge 5 commits intoeclipse-iceoryx:mainfrom
patdhlk wants to merge 5 commits intoeclipse-iceoryx:mainfrom
Conversation
…ncies Run Eclipse Dash License Tool per-project on all third-party NuGet dependencies (Microsoft/System/NETStandard/runtime filtered out). Add check-licenses.sh script and DEPENDENCIES file.
dkroenke
reviewed
Feb 25, 2026
- Link ticket eclipse-iceoryx#17 in CHANGELOG.md entry - Reference DEPENDENCIES file from NOTICE.md third-party content section - Update test dependencies to latest versions (xunit 2.9.3, xunit.runner.visualstudio 2.8.2, Microsoft.NET.Test.Sdk 18.3.0) - Regenerate DEPENDENCIES via Eclipse Dash Tool; all 12 deps now approved
The macos-latest runner was updated to a newer macOS version where iceoryx2-pal-posix struct size assertions (sockaddr, ifaliasreq) fail. Pin to macos-14 until the iceoryx2 submodule supports the newer macOS.
Update iceoryx2 submodule from v0.8.0 to v0.8.1 which fixes the macOS build failure caused by struct size mismatches in iceoryx2-pal-posix. Revert macOS CI runner back to macos-latest since the root cause is resolved in the submodule.
The brew-installed LLVM (22.1.0) causes bindgen to generate incorrect struct sizes for sockaddr and ifaliasreq on the updated macOS runner. The upstream iceoryx2 CI does not install brew LLVM on macOS — the system clang/libclang is sufficient for building the FFI library.
dkroenke
reviewed
Apr 2, 2026
| @@ -0,0 +1,122 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
The script itself should have a copyright header as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Adds Eclipse Dash License Tool check for all third-party NuGet dependencies in the C# bindings.
Microsoft/System/NETStandard/NuGet/runtime packages are filtered out per the standard dash-licenses .NET convention.
Dependencies are checked per-project (libraries, tests, and examples independently).
The
DEPENDENCIESfile is generated byscripts/check-licenses.shwhich:dotnet list package --include-transitiveResults: 6 approved, 6 restricted (xunit packages — all Apache-2.0, need iplab review).
Pre-Review Checklist for the PR Author
Convert to draft)csharp-iox2-123-short-description)[#123] Add feature description)PR Reviewer Reminders
dotnet formathas been exectued before submittingReferences
Closes #17