Compact.Serialize alters the original token#114
Open
AdrianFinnegan wants to merge 1 commit intodvsekhvalnov:masterfrom
Open
Compact.Serialize alters the original token#114AdrianFinnegan wants to merge 1 commit intodvsekhvalnov:masterfrom
AdrianFinnegan wants to merge 1 commit intodvsekhvalnov:masterfrom
Conversation
…is used. Therefore when calling the Verify stage the certificate is invalid, as the token is not the same as the one that was originally signed
Owner
|
Hi @AdrianFinnegan , i'm really sorry somehow github notifications stopped showing on my phone ( i'm missing stuff. Do we have opened issue associated with pull request? Just trying to understand what it is solving. And also minimal unit tests showing original problem gone would be really nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compact.Serialize() reconstitutes the header.payload, but if the original was padded this step does not include the padding. This means when you get to the
if (!jwsAlgorithmImpl.Verify(signature, securedInput, key)){}step then the verification fails; not because it's invalid but because the token being verified isn't the same token passed to the method.