Skip to content

(ENG)[droidknights#438] Network 객체 생성시 명시적 클래스 선언을 inline-reified 로 변경#437

Merged
taehwandev merged 2 commits intodroidknights:2025/appfrom
SeongUgJung:eng_improve_readibility
May 27, 2025
Merged

(ENG)[droidknights#438] Network 객체 생성시 명시적 클래스 선언을 inline-reified 로 변경#437
taehwandev merged 2 commits intodroidknights:2025/appfrom
SeongUgJung:eng_improve_readibility

Conversation

@SeongUgJung
Copy link
Copy Markdown
Contributor

@SeongUgJung SeongUgJung commented May 26, 2025

Issue

Overview (Required)

- -
before droidknightsNetwork.create(
    baseUrl = droidknightsBuildConfig.userDroidknightsUrl(),
    service = DroidnightsContributorsApi::class.java
)
after droidknightsNetwork.create<DroidnightsContributorsApi>(
    baseUrl = droidknightsBuildConfig.userDroidknightsUrl()
)

@taehwandev
Copy link
Copy Markdown
Member

@SeongUgJung 이슈도 등록해주세요.

@taehwandev
Copy link
Copy Markdown
Member

@SeongUgJung 원래 룰은 이슈 생성 > 어사인 > 작업입니다.

@SeongUgJung SeongUgJung force-pushed the eng_improve_readibility branch from c7b4078 to 718b635 Compare May 26, 2025 09:03
@SeongUgJung SeongUgJung changed the title (ENG) Network 객체 생성시 명시적 클래스 선언을 inline-reified 로 변경 Network 객체 생성시 명시적 클래스 선언을 inline-reified 로 변경 May 26, 2025
@SeongUgJung SeongUgJung changed the title Network 객체 생성시 명시적 클래스 선언을 inline-reified 로 변경 (ENG)[droidknights#438] Network 객체 생성시 명시적 클래스 선언을 inline-reified 로 변경 May 26, 2025
@github-actions
Copy link
Copy Markdown

Test Results

29 tests   29 ✅  20s ⏱️
17 suites   0 💤
17 files     0 ❌

Results for commit f1c96d1.

@taehwandev
Copy link
Copy Markdown
Member

고생하셨습니다.

@taehwandev taehwandev merged commit b8075da into droidknights:2025/app May 27, 2025
3 checks passed
@SeongUgJung SeongUgJung deleted the eng_improve_readibility branch May 27, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants