fix(drizzle-orm): Return an object when any values is non-null during a grouped left/right join (#2157)#5559
Open
AaronGibbison wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
|
What a crazy coincidence that you open this on the same day I find another bug in my app related to this. Thanks! |
…eft/right join When doing a grouped left/right join, the entire object is incorrectly defined as null if the first value returned is null. Further entries are checked for a non-null values, and ensures the returned object is defined if any value was not null
ebfd94e to
1816f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When deserialising grouped objects, if the first value of an object of a left/right join is null, the entire object is defined as null regardless of the result of later values. Returned results are incomplete, missing data from a successful join.
Root Cause
Fix
When mapping grouped objects result, if any values of the object is not-null, then classify the entire object as not-null.
Related
Fixes #2157