Conversation
Ryu4fly
changed the title
tomonorman
suggested changes
Mar 31, 2022
| @@ -427,10 +429,18 @@ protected function processRequest() | |||
| $error = Curl::getError(); | |||
| $code = array_get($error, 'code', 500); | |||
There was a problem hiding this comment.
Just wondering. if you do a dd() on the $error variable, does it contain anything else except the 'code'? It it has a message maybe we can just use that.
| $error = Curl::getError(); | ||
| $code = array_get($error, 'code', 500); | ||
| $status = $code; | ||
| $CurlNumCodeArr = array_keys(CURLCODE); |
There was a problem hiding this comment.
variable should be lowercase. Perhaps $curlErrorCodeList is easier to read.
| @@ -0,0 +1,92 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Assuming that these messages are not in the $error variable as mentioned above, perhaps we can add all of this as its own file in df-core Enums (like the verbmasks are in this file). That would make it more usable if other services need to use this list in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.