π¦ Dracula: use bat emoji for battery#381
Conversation
π WalkthroughWalkthroughDocumentation update replacing a heart icon with a bat icon in the battery widget configuration example within Changes
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~2 minutes π₯ Pre-merge checks | β 2 | β 1β Failed checks (1 warning)
β Passed checks (2 passed)
βοΈ Tip: You can configure your own custom pre-merge checks in the settings. β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
scripts/battery.sh
Outdated
| bat_label="π¦" | ||
| fi | ||
|
|
||
| if [ "$bat_label" == false ]; then |
There was a problem hiding this comment.
This if statement is identical to the one starting above on line 164. Please remove it
|
hi, we have an option for that. |
|
I think this PR is meant to be an Easter egg of sorts lol |
aight, in that case i'll leave further decisions regarding this pr to you π |
|
I mean tbh I don't see much value in it either. |
|
Yes, it's meant to be fun. Just an Easter egg since it's the Dracula theme. π |
|
we could change line 204 in CONFIG.md from |
|
I'm good with that solution |
|
Same. π I'll make the change soon. |
Seems to me that it would make sense for the battery indicator for the Dracula theme to be a bat
I implemented it as an option rather than making it the default