fix: Inlcude FKs when creating marshmallow-sqlalchemy schemas#2443
Open
mschmo wants to merge 4 commits into
Open
fix: Inlcude FKs when creating marshmallow-sqlalchemy schemas#2443mschmo wants to merge 4 commits into
mschmo wants to merge 4 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Defaults to true for top-level schemas, and set as false for nested schemas.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2361 and #2425
In marshmallow-sqlalchemy 1.x, the
SQLAlchemyAutoSchemaclass defaultsinclude_fkto False. When FAB generates the schemas for security models likePermissionView, it explicitly requests foreign key columns (likepermission_idandview_menu_id). However, becauseinclude_fkis False, theSQLAlchemyAutoSchemaMetametaclass filters these fields out before the schema is initialized. Marshmallow 4 then throws a KeyError (due to this change) because it expects all fields listed inMeta.fieldsto be present in the schema.In order to preserve existing API behavior,
include_fkis set to False when generating nested schemas for relationship fields.