[ci-scan] Skip System.Formats.Nrbf.Tests on Mono CI#128112
Open
github-actions[bot] wants to merge 2 commits into
Open
[ci-scan] Skip System.Formats.Nrbf.Tests on Mono CI#128112github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
The entire test assembly consistently times out when running on Mono (MonoJIT and MonoInterpreter). Skip it on Mono CI until the root cause is resolved. Linked KBE: #128079 Tracking: #126636 Co-authored-by: Copilot <[email protected]>
Member
|
Noise in the CI, I suggest disabling it on Mono and keeping the tracking issue. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the System.Formats.Nrbf.Tests test project configuration to be excluded from CI runs when testing with the Mono runtime flavor, aligning with existing repo patterns for skipping known-problematic test projects on specific CI legs.
Changes:
- Adds an
IgnoreForCIproperty conditioned on$(RuntimeFlavor) == 'Mono'to prevent theSystem.Formats.Nrbf.Testsassembly from being archived/run in CI for Mono. - Documents the skip with a direct link to the tracking issue.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Formats.Nrbf/tests/System.Formats.Nrbf.Tests.csproj | Adds conditional IgnoreForCI for Mono CI runs, with issue link documenting the rationale. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
vitek-karas
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked KBE: #128079
Tracking: #126636
Skips the
System.Formats.Nrbf.Teststest assembly on Mono CI using<IgnoreForCI>. The entire assembly consistently times out on Mono (both MonoJIT and MonoInterpreter legs).Verification
System.Formats.Nrbf.Testsis the full assembly that times out.Command timed out, and was killedon the entire work item.Failing legs
The
IgnoreForCIis scoped toRuntimeFlavor == 'Mono'only, matching the observed failure scope.Note
🔒 Integrity filter blocked 3 items
The following items were blocked because they don't meet the GitHub integrity level.
search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: