Refactor conditional logic for handling application endpoints in GraphMinimalPermissionsGuidancePlugin. Closes #1605#1606
Merged
garrytrinder merged 3 commits intodotnet:mainfrom Apr 9, 2026
Conversation
…hMinimalPermissionsGuidancePlugin. Closes dotnet#1605
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors how GraphMinimalPermissionsGuidancePlugin collects application endpoints during recording playback so it evaluates minimal application permissions across all captured Graph requests (aligning with issue #1605’s “only evaluated GET /groups” symptom).
Changes:
- Ensures application endpoints are always added to
applicationEndpointsfor each application-typed request. - Keeps the “roles to evaluate” capture behavior (set once from the first request that contains roles), while decoupling it from endpoint collection.
garrytrinder
approved these changes
Apr 9, 2026
Contributor
garrytrinder
left a comment
garrytrinder
left a comment
There was a problem hiding this comment.
Tested with 4 application-permission Graph requests (GET /groups, GET /groups/{id}/members, GET /teams/{id}, GET /groups/{id}/settings) using a JWT with roles claims. All endpoints correctly evaluated and minimal permissions computed. Fix confirmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor conditional logic for handling application endpoints in GraphMinimalPermissionsGuidancePlugin. Closes #1605