fix(k8s-views-pods): use exact pod match in Information section stat panels#178
Open
raman1236 wants to merge 1 commit intodotdc:masterfrom
Open
fix(k8s-views-pods): use exact pod match in Information section stat panels#178raman1236 wants to merge 1 commit intodotdc:masterfrom
raman1236 wants to merge 1 commit intodotdc:masterfrom
Conversation
…panels The Information section stat panels are designed for single-pod display (they show metadata like Created by, Running on, Pod IP, etc.). Using regex matching (pod=~) causes them to return multiple values when $pod=All is selected, resulting in unreadable tiny text in stat panels. Revert these 7 Information panels from pod=~ to pod= while keeping regex matching for all Resource/Kubernetes/Network panels where multi-pod display is intended. Fixes dotdc#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #177
The Information section stat panels in
k8s-views-podsare designed for single-pod metadata display (Created by, Running on, Pod IP, Priority Class, QOS Class, Last Terminated Reason/Exit Code).After #173 changed
pod="$pod"topod=~"$pod"across all panels, these 7 stat panels now match multiple pods when$pod=Allis selected. Since stat panels render all matched values, this produces very small, unreadable text.Fix
Revert the 7 Information section stat panels from regex matching (
pod=~"$pod") to exact matching (pod="$pod"), consistent with their"Panel only works when a single pod is selected."description.All other sections (Resources, Kubernetes, Network) keep regex matching since their panel types (timeseries, table, gauge) handle multi-pod data correctly.
Affected panels
kube_pod_infokube_pod_infokube_pod_infokube_pod_infokube_pod_status_qos_classkube_pod_container_status_last_terminated_reasonkube_pod_container_status_last_terminated_exitcode