fix(style-editor): Now the style editor form is showed in UVE#35497
Conversation
…PI and utils tests - Updated tests in and to use instead of for logging warnings. - Adjusted the implementation in and to directly call for logging messages related to missing page queries and schema fetch failures. - Removed unnecessary imports of from the test files to streamline the codebase. This change enhances consistency in logging practices across the codebase.
|
Claude finished @zJaaal's task in 1m 36s —— View job PR Review
Core fix is correct. Removing the The duplicate import removal in Issues worth flagging1. Spy not restored — test leak ( const consolaWarnSpy = jest.spyOn(console, 'warn');
// ... assertions ...
// missing: consolaWarnSpy.mockRestore()The spy is never torn down with 2. Stale test description ( it('should omit styleEditorSchemas and log debug when schema endpoint fails', ...The implementation now logs at 3. Inconsistent logging — partial consola migration
4. For generic/non-auth errors (network timeouts, unexpected 500s), what was a debug-level hint is now a warning. In SSR environments where the schema endpoint may be unavailable or unreachable, this will emit noisy warnings on every page render. If the intent is that these errors should be visible, that's fine — but it contradicts the "silently ignored" docstring and changes observable behavior. No other issues. |
…r handling - Changed logging from to in and to improve clarity in error reporting. - Updated the implementation in to reflect the same change, ensuring consistent logging practices across the codebase. This enhances the visibility of non-auth errors and aligns with the recent refactor of logging practices.
…se-content-type-tab-as-single-source-of-truth-for-headless-and-traditional-pages-qa-failed-i
2026-04-28.17-35-27.mov
This change enhances consistency in logging practices across the codebase.
This PR fixes: #35270
This PR fixes: #35270