Skip to content

make docopt as function instead of macros#5

Open
signalpillar wants to merge 1 commit intodocopt:masterfrom
signalpillar:patch-1
Open

make docopt as function instead of macros#5
signalpillar wants to merge 1 commit intodocopt:masterfrom
signalpillar:patch-1

Conversation

@signalpillar
Copy link
Copy Markdown

Fix issue when docstring passed as first argument explicitly - parse function fails on (string? doc) assert

It happens due to the fact that passed doc variable at compile time will point to symbol not an actual value.
I have got rid of macros at all as it is recommended to use functions when it is possible

Fix issue 
> Caused by: java.lang.Exception: Docopt with one argument requires that #'-main have a doc string.

It happens due to the fact that passed `doc` variable at compile time will point to symbol not an actual value
@mgrubb
Copy link
Copy Markdown

mgrubb commented Oct 9, 2013

@postamar is this project still being maintained?

@benzap
Copy link
Copy Markdown

benzap commented Mar 21, 2015

They need to add another clojure collaborator for this, I think the maintainer of this got busy.

@keleshev
Copy link
Copy Markdown
Member

Anyone volunteers to be a new maintainer?

@keleshev
Copy link
Copy Markdown
Member

@postamar please let us know if you are still interested in this project.

@postamar
Copy link
Copy Markdown

Sure! Sorry for not responding sooner. Please give me a few days to get up to date, I'll be more active henceforth, and if I can't, I'll let you know.

@carocad
Copy link
Copy Markdown

carocad commented Sep 15, 2015

Hey @keleshev, @mgrubb, @signalpillar and @benzap
I created a first alpha version of a complete rewrite of the docopt clojure implementation. If you could check it out and give some feedback and submit any pull-request I would greatly appreciate it :)
IMO the new implementation is extremely easy to understand and is quite concise (<200 loc) so hacking it shouldnt be a problem.

Loooking forward to your feedback

@oemmerson
Copy link
Copy Markdown

@postamar Currently the example in the readme doesn’t work with the version on Clojars!

Please can you at least fix the issue with the -main docstring being parsed, bump the version number and upload to Clojars?

Perhaps you can also add @carocad as a maintainer since he has taken the time to do a simpler re-write that may be the future of the project.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants