Improve messages for assembly filterin/filterout#265
Open
tomschr wants to merge 1 commit intodocbook:masterfrom
Open
Improve messages for assembly filterin/filterout#265tomschr wants to merge 1 commit intodocbook:masterfrom
tomschr wants to merge 1 commit intodocbook:masterfrom
Conversation
The INFO message contains now the module or structure with @resourceref or @xml:id attributes. This makes it easier to see what happens and helps to debug issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the INFO message when
<filterin/>or<filterout/>is used in an assembly file.IMHO, the current message does not provide much information when something happens:
This makes it hard to debug or to trace down issues in an assembly file.
This PR improves the message and includes the name of the parent element (usually
<module>orstructure) and either or both@resourcerefor@xml:idattributes.The new message looks like this:
Perhaps we could change the wording a bit.
@bobstayton Let me know if you think this can be useful. 🙂