Don’t duplicate id attributes when styling coref elements#631
Merged
ndw merged 1 commit intodocbook:mainfrom Sep 13, 2025
ndw:iss-629
Merged
Don’t duplicate id attributes when styling coref elements#631ndw merged 1 commit intodocbook:mainfrom ndw:iss-629
ndw merged 1 commit intodocbook:mainfrom
ndw:iss-629
Conversation
Fix #629 This PR also changes the element that wraps a co from “a” to “span”. That’s possibly backwards incompatible, but seems unlikely to be harmful and “a” is clearly wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #629
Close #630
This PR also changes the element that wraps a co from “a” to “span”. That’s possibly backwards incompatible, but seems unlikely to be harmful and “a” is clearly wrong.