check if table width exceeds nominal page width more than treshold#610
Closed
fsteimke wants to merge 2 commits intodocbook:mainfrom
Closed
check if table width exceeds nominal page width more than treshold#610fsteimke wants to merge 2 commits intodocbook:mainfrom
fsteimke wants to merge 2 commits intodocbook:mainfrom
Conversation
See docbook#609. Switch to relative width occurs only if sum of column widths exceeds `$nominal-page-width` by more than a `$treshold`, which is `1px`. This helps to avoid false positive test because of rounding errors. Analysis shows a potential issue with `f:absolute-length` in module `units.xsl`: although the value is rounded without fraction digits, the function signature gives it the type `xs:double`. I think function signature should be changed to ``` <xsl:function name="f:absolute-length" as="xs:nonNegativeInteger"> ``` If table width really exceeds `nominal-page-width`, the error message is optimized and informs about the amount of exceeding as well as the path of the table in question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #609. Switch to relative width occurs only if sum of column widths exceeds
$nominal-page-widthby more than a$treshold, which is1px. This helps to avoid false positive test because of rounding errors.Analysis shows a potential issue with
f:absolute-lengthin moduleunits.xsl: although the value is rounded without fraction digits, the function signature gives it the typexs:double. I think function signature should be changed toIf table width really exceeds
nominal-page-width, the error message is optimized and informs about the amount of exceeding as well as the path of the table in question.