Dark theme and icon to toggle theme#682
Conversation
|
Attempt number 2 😛 |
|
Can you get a tooltip on the icon you've added to say what it does? |
|
Tooltip and injection vulnerability from cookie added. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| function dvwaThemeGet() { | ||
| if (isset($_COOKIE['theme'])) { | ||
| return $_COOKIE[ 'theme' ]; |
Check failure
Code scanning / PHP Security Analysis
Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error
|
|
||
| function dvwaThemeGet() { | ||
| if (isset($_COOKIE['theme'])) { | ||
| return $_COOKIE[ 'theme' ]; |
Check failure
Code scanning / PHP Security Analysis
Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error
|
|
||
| function dvwaThemeGet() { | ||
| if (isset($_COOKIE['theme'])) { | ||
| return $_COOKIE[ 'theme' ]; |
Check failure
Code scanning / PHP Security Analysis
Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error
|
|
||
| function dvwaThemeGet() { | ||
| if (isset($_COOKIE['theme'])) { | ||
| return $_COOKIE[ 'theme' ]; |
Check failure
Code scanning / PHP Security Analysis
Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error
|
|
||
| function dvwaThemeGet() { | ||
| if (isset($_COOKIE['theme'])) { | ||
| return $_COOKIE[ 'theme' ]; |
Check failure
Code scanning / PHP Security Analysis
Detected tainted HTML: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error
|
|
||
| function dvwaThemeGet() { | ||
| if (isset($_COOKIE['theme'])) { | ||
| return $_COOKIE[ 'theme' ]; |
Check failure
Code scanning / PHP Security Analysis
Detected tainted text with possible quotes: $_COOKIE['theme']\ndvwaThemeGet\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\nconcat\ncall to echo. Error
|
GitHub code scanner doesn't like it, I'm happy with that!
|
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
Dark theme and icon to toggle theme
3 participants
Dark theme perfect for late night hacking. Icon is from Material Design : https://pictogrammers.com/library/mdi/