feat: update directory bindings schema for jamfpro_policy (add name, remove id)#1012
Merged
ShocOne merged 29 commits intodeploymenttheory:mainfrom Feb 17, 2026
Conversation
…s (11.19) (deploymenttheory#845) refactor: jamf_cloud_distribution_service changes for Jamf Pro 11.19
…1.19) (deploymenttheory#848) feat: Add username attribute claim mapping to jamfpro_sso_settings for 11.19
…ment_settings (deploymenttheory#849) feat: Add enable_maid_username_merge option for user initiated enrollment settings
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…theory#853) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.27.0 to 0.28.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-version: 0.28.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
|
Please confirm you have:
Cheers |
…s-schema-2026-02-12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
Switch directory bindings to use name-only (drop id) across schema, constructor, and state to prevent Jamf API errors. Classic API behaviour requires only the name field, not id, for directory bindings.
This does not require state migration as we've removed a field and added a new one.
Since any attempt to declare a directory binding in a policy currently generates an API error or a provider crash due to #1007, folks using the provider will not have been managing this payload with it previously.
Issue Reference
Fixes #1007
Motivation and Context
Dependencies
Type of Change
Please mark the relevant option with an
x:Testing
Quality Checklist
Screenshots/Recordings (if appropriate)
[Add screenshots or recordings that demonstrate the changes]
Additional Notes
[Add any additional information that might be helpful for reviewers]