Skip to content

feat: update directory bindings schema for jamfpro_policy (add name, remove id)#1012

Merged
ShocOne merged 29 commits intodeploymenttheory:mainfrom
neilmartin83:nm-policy-directory-bindings-schema-2026-02-12
Feb 17, 2026
Merged

feat: update directory bindings schema for jamfpro_policy (add name, remove id)#1012
ShocOne merged 29 commits intodeploymenttheory:mainfrom
neilmartin83:nm-policy-directory-bindings-schema-2026-02-12

Conversation

@neilmartin83
Copy link
Copy Markdown
Contributor

Pull Request Description

Summary

Switch directory bindings to use name-only (drop id) across schema, constructor, and state to prevent Jamf API errors. Classic API behaviour requires only the name field, not id, for directory bindings.

This does not require state migration as we've removed a field and added a new one.

Since any attempt to declare a directory binding in a policy currently generates an API error or a provider crash due to #1007, folks using the provider will not have been managing this payload with it previously.

Issue Reference

Fixes #1007

Motivation and Context

  • Why is this change needed?
  • What problem does it solve?
  • If it fixes an open issue, please link to the issue here

Dependencies

  • List any dependencies that are required for this change
  • Include any configuration changes needed
  • Note any version updates required

Type of Change

Please mark the relevant option with an x:

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update (Wiki/README/Code comments)
  • ♻️ Refactor (code improvement without functional changes)
  • 🎨 Style update (formatting, renaming)
  • 🔧 Configuration change
  • 📦 Dependency update

Testing

  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added integration tests following the testing implementation guide
  • I have tested this code in the following browsers/environments: Local environment

Quality Checklist

  • I have reviewed my own code before requesting review
  • I have verified there are no other open Pull Requests for the same update/change
  • All CI/CD pipelines pass without errors or warnings
  • My code follows the established style guidelines of this project
  • My comments are used only when necessary, ideally where the codes purpose is not self explanatory (eg: necessary magic numbers)
  • I have added necessary documentation (if appropriate)
  • I have made corresponding changes to the README and other relevant documentation
  • My changes generate no new warnings

Screenshots/Recordings (if appropriate)

[Add screenshots or recordings that demonstrate the changes]

Additional Notes

[Add any additional information that might be helpful for reviewers]

neilmartin83 and others added 28 commits August 14, 2025 14:29
…s (11.19) (deploymenttheory#845)

refactor: jamf_cloud_distribution_service changes for Jamf Pro 11.19
…1.19) (deploymenttheory#848)

feat: Add username attribute claim mapping to jamfpro_sso_settings for 11.19
…ment_settings (deploymenttheory#849)

feat: Add enable_maid_username_merge option for user initiated enrollment settings
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…theory#853)

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.27.0 to 0.28.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.28.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@neilmartin83 neilmartin83 requested review from a team and ShocOne as code owners February 12, 2026 11:58
@neilmartin83 neilmartin83 temporarily deployed to provider-integration-testing-external February 12, 2026 11:58 — with GitHub Actions Inactive
@thejoeker12
Copy link
Copy Markdown
Contributor

@neilmartin83

Please confirm you have:

  • Tested an implementation with the current latest release version
  • Migrated to this version
  • Confirmed there are no errors after an apply

Cheers

@neilmartin83 neilmartin83 temporarily deployed to provider-integration-testing-external February 17, 2026 14:44 — with GitHub Actions Inactive
Copy link
Copy Markdown
Member

@ShocOne ShocOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ShocOne ShocOne merged commit 99f3bed into deploymenttheory:main Feb 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Crash with directory_bindings in scope due to difference in schema

3 participants