Skip to content

ci: build riscv64#1948

Open
Xeonacid wants to merge 1 commit intodenoland:mainfrom
riscv-forks:copilot/add-riscv64-cross-compilation-support
Open

ci: build riscv64#1948
Xeonacid wants to merge 1 commit intodenoland:mainfrom
riscv-forks:copilot/add-riscv64-cross-compilation-support

Conversation

@Xeonacid
Copy link
Copy Markdown

Unlike aarch64, the riscv64 sccache binary is not static, so use the host architecture one. 1

Copilot AI review requested due to automatic review settings March 30, 2026 15:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI coverage and build configuration for riscv64 (Linux) builds, including sysroot setup and workflow matrix expansion. It also adjusts sccache handling to avoid using a non-static riscv64 sccache binary by falling back to the host architecture binary.

Changes:

  • Add GN args + sysroot installation for riscv64 targets in build.rs.
  • Extend GitHub Actions CI matrix to build/test riscv64gc-unknown-linux-gnu (debug/release, with and without simdutf).
  • Add a riscv64 cross-compilation toolchain install step and adjust sccache platform selection for riscv64.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
build.rs Adds riscv64 target CPU + sysroot install logic for V8 GN generation.
.github/workflows/ci.yml Adds riscv64 CI jobs, installs riscv64 cross toolchain/QEMU, and maps riscv64 to host sccache binary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SCCACHE_IDLE_TIMEOUT: 0
run: |
$version = "v0.8.2"
$version = "v0.14.0"
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sccache version is bumped to v0.14.0 for the main build job, but other jobs in this workflow still pin sccache to v0.8.2. If the version bump is intentional, consider updating the other sccache install steps (or centralizing the version into a single env/variable) to avoid inconsistent behavior and harder-to-debug CI issues across jobs.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants