revert: bring back Babel CJS transform#3798
Merged
bartlomieju merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
Merged
bartlomieju
added a commit
that referenced
this pull request
Apr 28, 2026
## Summary - Bump `@fresh/core` 2.3.2 → 2.3.3 - Bump `@fresh/plugin-vite` 1.1.1 → 1.1.2 - Bump `@fresh/init` 2.3.2 → 2.3.3 - Bump `@fresh/update` 2.3.2 → 2.3.3 Reverts the broken CJS shim (#3798) and releases the restored Babel CJS transform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts two commits that broke CJS package handling in dev mode:
The simplified CJS shim introduced in #3767 has two fundamental issues:
code.includes("export ")) is fooled by comments containing "export"export default module.exports, soimport { trace } from "@opentelemetry/api"returnsundefined(Cannot read properties of undefined (reading 'getTracer') #3797)The Babel-based transform handled both correctly. Bringing it back until we can replace it with a proper solution using
deno_ast's CJS parser.Test plan