fix: handle commas in static file paths#3770
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Apr 22, 2026
Merged
Conversation
…duction Move the decode/re-encode logic into a local `normalizePathname` helper instead of importing `systemPathToUrlEncoded` from `dev_build_cache.ts`, which pulls the entire dev module graph into the production middleware. Also narrow the catch clause to only handle URIError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #3659, static file handling correctly supports spaces and encoded paths,
but filenames containing commas are not resolved.
Example:
foo,bar.css/foo%2Cbar.css/foo,bar.cssThis causes a mismatch and the static file is not found.
Cause
prepareStaticFile()stores file paths using URL encoding, whilestatic_files.tscompares againsturl.pathnamewithout applying the samenormalization.
Solution
Normalize the incoming request pathname using the same encoding logic before
reading from the build cache.
Tests
Added
static files - comma in pathnameto verify that both of these resolve:/foo,bar.css/foo%2Cbar.css