refactor(update): remove use of @std/fmt/colors#2887
refactor(update): remove use of @std/fmt/colors#2887iuioiua wants to merge 1 commit intodenoland:mainfrom iuioiua:remove-colors-update
@std/fmt/colors#2887Conversation
marvinhagemeister
left a comment
There was a problem hiding this comment.
This breaks color output in macOS' built-in Terminal app. That one famously doesn't support 16bit truecolor and only up to ansi256.
import * as colors from "jsr:@std/fmt/colors";
console.log("Before:");
console.log(colors.bgRgb8(
colors.rgb8(" 🍋 Fresh Updater ", 0),
121,
));
console.log();
console.log("With this PR:");
console.log("%c 🍋 Fresh Updater ", "background-color: #87ffaf; color: black;");
|
Ah, yes, that's right! In that case, I'd almost go as far as to say that any background styling in |
|
Yeah the first one would fix it. We don't have any code in the console at the moment to convert from 16bit colors to ansi256. |
|
I've done no prior reading on how it all works, so I have essentially zero context. It'd be great if we can re-open and complete that PR. From what I remember, tests were all that remain. Is that correct? Fixing that would also help fix https://github.com/denoland/std/blob/6a00d6cd34ca70b3a38932e313151a80531c5d2b/internal/build_message.ts#L29. |
This module simply isn't needed as
consolemethods support CSS styles natively.