Skip to content

BREAKING(core): remove Mode type#2884

Merged
marvinhagemeister merged 1 commit intodenoland:mainfrom
iuioiua:remove-mode
May 5, 2025
Merged

BREAKING(core): remove Mode type#2884
marvinhagemeister merged 1 commit intodenoland:mainfrom
iuioiua:remove-mode

Conversation

@iuioiua
Copy link
Copy Markdown
Contributor

@iuioiua iuioiua commented May 3, 2025

It doesn't seem like it deserves to be it's own type. It can just be an interface property.

Copy link
Copy Markdown
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit e0ca942 into denoland:main May 5, 2025
5 of 7 checks passed
@iuioiua iuioiua deleted the remove-mode branch May 5, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants