Fix: custom_ignore_diagnostic_directive not respected in LinterOptions#1474
Open
siddharthdewangan wants to merge 1 commit intodenoland:mainfrom
Open
Fix: custom_ignore_diagnostic_directive not respected in LinterOptions#1474siddharthdewangan wants to merge 1 commit intodenoland:mainfrom
siddharthdewangan wants to merge 1 commit intodenoland:mainfrom
Conversation
Updated custom ignore diagnostic directive for line ignore while creating LinterContext.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue :
#1475
What does this PR do?
Fixes a bug where
custom_ignore_diagnostic_directivewas ignored andcustom_ignore_file_directivewas mistakenly used for line-level ignores.Root cause
In
LinterContext::new,ignore_diagnostic_directivewas initializedusing
custom_ignore_file_directive.Fix
Use
custom_ignore_diagnostic_directivefor diagnostic-level ignores.Impact
``