Skip to content

Add did:andorra driver#515

Closed
davidgbvargroup wants to merge 2 commits intodecentralized-identity:mainfrom
davidgbvargroup:add-did-andorra-driver
Closed

Add did:andorra driver#515
davidgbvargroup wants to merge 2 commits intodecentralized-identity:mainfrom
davidgbvargroup:add-did-andorra-driver

Conversation

@davidgbvargroup
Copy link
Copy Markdown
Contributor

Add Universal Resolver Driver for did:andorra

This PR adds support for the did:andorra DID method to the Universal Resolver.

DID Method Information

Test Identifiers

  • did:andorra:NRTAD-710646J
  • did:andorra:NRTAD-059888N_ISS
  • did:andorra:NRTAD-059888N_SP

Changes Made

  • Added driver-did-andorra service to docker-compose.yml
  • Added driver configuration to uni-resolver-web/src/main/resources/application.yml
  • Updated README.md with did:andorra entry

Authority & Governance

  • Maintainer: David Garcia Beatove ([email protected])
  • Organization: VarGroup Iberia (on behalf of Government of Andorra)
  • Authority: Government of Andorra
  • Registry: NRTAD (Número de Registre Tributari d'Andorra)
  • Governance: OSCEPA (Oficina de Servicios de Certificación y Protección Andorrana)

Testing

Driver has been tested locally and resolves DIDs successfully from the official Andorra registry.

  - Add driver-did-andorra service to docker-compose.yml
   - Add driver configuration to application.yml
   - Update README.md with did:andorra entry
@BernhardFuchs
Copy link
Copy Markdown
Member

Just tested the driver and it throws following error on startup:

file:///usr/src/app/index.js:3
var http = require('http');
           ^

ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/usr/src/app/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///usr/src/app/index.js:3:12
    at ModuleJob.run (node:internal/modules/esm/module_job:345:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:665:26)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)

Node.js v22.20.0

@davidgbvargroup
Copy link
Copy Markdown
Contributor Author

Hi @BernhardFuchs,

Thanks for testing! I've fixed this issue - the code was mixing CommonJS and ES modules.

It should work now. Let me know if you still have issues.

Thanks!

Comment thread docker-compose.yml Outdated
- "8163:8080"

driver-did-andorra:
image: davidgbvargroup/uni-resolver-driver-did-andorra:1.0.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls build a new image and update here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BernhardFuchs,

Done! I've built a new image with version 1.0.1 , the PR has been updated to use version 1.0.1.

Thanks!

@BernhardFuchs
Copy link
Copy Markdown
Member

The driver works but there were some changes in the meanwhile. I merged everything and added your driver with PR #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants