Add did:andorra driver#515
Closed
davidgbvargroup wants to merge 2 commits intodecentralized-identity:mainfrom
Closed
Add did:andorra driver#515davidgbvargroup wants to merge 2 commits intodecentralized-identity:mainfrom
davidgbvargroup wants to merge 2 commits intodecentralized-identity:mainfrom
Conversation
- Add driver-did-andorra service to docker-compose.yml - Add driver configuration to application.yml - Update README.md with did:andorra entry
Member
|
Just tested the driver and it throws following error on startup: |
Contributor
Author
|
Hi @BernhardFuchs, Thanks for testing! I've fixed this issue - the code was mixing CommonJS and ES modules. It should work now. Let me know if you still have issues. Thanks! |
| - "8163:8080" | ||
|
|
||
| driver-did-andorra: | ||
| image: davidgbvargroup/uni-resolver-driver-did-andorra:1.0.0 |
Member
There was a problem hiding this comment.
Pls build a new image and update here
Contributor
Author
There was a problem hiding this comment.
Hi @BernhardFuchs,
Done! I've built a new image with version 1.0.1 , the PR has been updated to use version 1.0.1.
Thanks!
Member
|
The driver works but there were some changes in the meanwhile. I merged everything and added your driver with PR #522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Universal Resolver Driver for did:andorra
This PR adds support for the
did:andorraDID method to the Universal Resolver.DID Method Information
did:andorraTest Identifiers
did:andorra:NRTAD-710646Jdid:andorra:NRTAD-059888N_ISSdid:andorra:NRTAD-059888N_SPChanges Made
driver-did-andorraservice todocker-compose.ymluni-resolver-web/src/main/resources/application.ymlREADME.mdwith did:andorra entryAuthority & Governance
Testing
Driver has been tested locally and resolves DIDs successfully from the official Andorra registry.