DBZ-8911 Add configuration to skip heartbeat messages in Redis Stream consumer#173
DBZ-8911 Add configuration to skip heartbeat messages in Redis Stream consumer#173jpechane merged 1 commit intodebezium:mainfrom
Conversation
spicy-sauce
changed the title
spicy-sauce
force-pushed
the
DBZ-8911
branch
2 times, most recently
from
ecdd03c to
3de60c9
Compare
jpechane
left a comment
jpechane
left a comment
There was a problem hiding this comment.
@spicy-sauce LGTM, thanks! I just left one comment wrt variable naming and request for slight change in tests. When addressed this is good to go.
| Map<String, Object> sourceConfig = getConfigSubset(mpConfig, "debezium.source."); | ||
|
|
||
| // Get Redis sink configuration | ||
| Configuration configuration = Configuration.from(getConfigSubset(mpConfig, "")); |
There was a problem hiding this comment.
| Configuration configuration = Configuration.from(getConfigSubset(mpConfig, "")); | |
| Configuration sinkConfig = Configuration.from(getConfigSubset(mpConfig, "")); |
There was a problem hiding this comment.
I don't think renaming to sinkConfig would be accurate. The variable contains all configuration properties, not just sink-specific ones. The name configuration is actually more appropriate here since it represents the complete set of properties, IMO.
Renaming it to sinkConfig would be misleading because it implies the configuration only contains sink-related properties, which isn't the case.
@jpechane WDYT?
|
|
||
| // Wait for some time to allow heartbeats to be generated | ||
| Testing.print("Waiting for heartbeats to be generated..."); | ||
| Thread.sleep(3000); |
There was a problem hiding this comment.
Could you please rewrite the test to not use Thread.sleep() but Awaitility that would wait (with timeout) till something is in heartbeat stream?
|
|
||
| // Wait for some time to allow heartbeats to be generated | ||
| Testing.print("Waiting for heartbeats to be generated..."); | ||
| Thread.sleep(3000); |
There was a problem hiding this comment.
See above, here you should probably wait for 2 in redis_test stream.
spicy-sauce
force-pushed
the
DBZ-8911
branch
2 times, most recently
from
2312869 to
a3570b8
Compare
|
It is a flaky test @spicy-sauce, fixed in #174 |
Thanks, merged |
|
@spicy-sauce Could you please remove the merge commit and use just plain rebase so we keep linear history? Thanks |
Done. |
|
@spicy-sauce Applied, thanks! |
3 participants
No description provided.