Add support for integer versions in unit test versions.include/exclude#1658
Add support for integer versions in unit test versions.include/exclude#1658grahamwetzler wants to merge 3 commits intodbt-labs:mainfrom
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @grahamwetzler |
|
This repository enforces signed commits. Please sign your commits by following the docs here. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
862b91f to
6e9145a
Compare
57bfc5e to
b81ecea
Compare
…exclude IncludeExclude used StringOrArrayOfStrings which has no Number variant, causing deserialization failures when YAML integers (e.g. `- 2`) appeared in unit_test versions.include or versions.exclude lists. Adds VersionIdentifier (number-or-string) and VersionOrVersionList types scoped to IncludeExclude, leaving StringOrArrayOfStrings unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Graham Wetzler <graham@wetzler.dev>
Signed-off-by: Graham Wetzler <graham@wetzler.dev>
b81ecea to
756556f
Compare
IncludeExclude used StringOrArrayOfStrings which has no Number variant, causing deserialization failures when YAML integers (e.g.
- 2) appeared in unit_test versions.include or versions.exclude lists.This was raised in #1613 but was not fixed.
Adds VersionIdentifier (number-or-string) and VersionOrVersionList types scoped to IncludeExclude, leaving StringOrArrayOfStrings unchanged.
Reproduction
When parsing a manifest passed in with
--stateor dbt platform deferral, dbt Fusion raises an error:data did not match any variant of untagged enum StringOrArrayOfStrings. Note that this only seems to happen with a dbt-core generated manifest – I couldn't reproduce using a dbt Fusion generated manifest.Unit test: