Conversation
jasnonaz
approved these changes
Jan 21, 2026
Contributor
jasnonaz
left a comment
jasnonaz
left a comment
There was a problem hiding this comment.
This looks is a really strong start. A few thoughts
-
I'm wondering if we want to bake in any of the guidance / nuances from the metrics best practice guide https://docs.getdbt.com/best-practices/how-we-build-our-metrics/semantic-layer-1-intro
-
We should consider additional files with:
- The new spec in full so it doesn't have to make a web call to get it
- More examples of various types of metrics
Co-authored-by: Jason Ganz <jason.ganz64@gmail.com>
Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for the SL skill