Build against Scala Native 0.5 and Scala.JS 1.20#165
Open
hugo-vrijswijk wants to merge 3 commits intodavenverse:mainfrom
Open
Build against Scala Native 0.5 and Scala.JS 1.20#165hugo-vrijswijk wants to merge 3 commits intodavenverse:mainfrom
hugo-vrijswijk wants to merge 3 commits intodavenverse:mainfrom
Conversation
Author
|
@ChristopherDavenport with the full CE and FS2 release this should be ready to go now 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FS2 3.7.x also opens up using Unix sockets to connect, which is interesting. But that is probably a separate PR.
Also updates many other dependencies, to get things working.
I removed
SocketGroupfrom usage inRedisConnection, and only deprecated thewithSocketGroupbuilder method. There was a test that I couldn't get working now that sockets are made by the Network[F] instance, so I removed it. If anyone knows how to get it working again I'll be happy to put it back (though removing the custom socket instance still had the test passing 🤔)