Fix CDCS REST API compatibility with NexusLIMS-CDCS 3.20.x#92
Merged
Conversation
…sion matrix
- Add trailing slashes to all CDCS REST API endpoint URLs in cdcs.py,
CDCSDestination, and integration tests (required by NexusLIMS-CDCS 3.20.x)
- Wrap legacy HyperSpy sig_to_thumbnail call in try/except to fall back
to placeholder image on failure; add test covering the new except branch
- Add docs/reference/compatibility.md with NexusLIMS / NexusLIMS-CDCS
version compatibility matrix and explanation of the -nx{n} tag format
- Cross-reference the compatibility page from the frontend guide overview,
production deployment, and configuration docs
- Exclude macOS resource fork files (._*) from Sphinx doc builds
jat255
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📚 Documentation PreviewThe documentation for this PR has been deployed to:
This preview will be updated on each push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
Summary
cdcs.py,CDCSDestination, and integration tests), required by NexusLIMS-CDCS 3.20.x (DjangoAPPEND_SLASH=Truereturns 500 on DELETE/PATCH without trailing slash)sig_to_thumbnailcall intry/exceptto fall back to a placeholder image on failure rather than raisingdocs/reference/compatibility.mdwith a NexusLIMS / NexusLIMS-CDCS version matrix and explanation of the-nx{n}tag format; cross-reference from the frontend guide overview, production, and configuration pages._*) from Sphinx doc builds to fix spurioustoc.not_includedwarnings91.misc.mdTest plan
test_create_preview_hyperspy_sig_to_thumbnail_raisescovers the new fallback path (lines 688-694 ofextractors/__init__.py)toc.not_includedwarnings for._*files