Fix csvlog duration leak for statement-only entries#879
Merged
Conversation
PostgreSQL csvlog entries logged as `statement:` without a `duration:` tag could inherit duration state from a previously parsed duration-bearing entry. This made pgBadger report statement-only queries as slow queries with incorrect total, min, and max durations. This change resets csvlog parser state for each row and updates stats merging so duration-related fields are only preserved when they are actually present. A regression test was added with synthetic csvlog data covering: - one duration-bearing query; - one statement-only query without duration; - verification that the statement-only query does not get duration/min/max fields.
Owner
|
Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL csvlog entries logged as
statement:without aduration:tag could inherit duration state from a previously parsed duration-bearing entry. This made pgBadger report statement-only queries as slow queries with incorrect total, min, and max durations.This change resets csvlog parser state for each row and updates stats merging so duration-related fields are only preserved when they are actually present.
A regression test was added with synthetic csvlog data covering: