fix: block path traversal in pattern name lookup#2123
Open
OdinKral wants to merge 1 commit into
Open
Conversation
…er#2094) Pattern names containing ".." could be used to escape the patterns directory and read arbitrary files via filepath.Join. Guard added at the top of getFromDB; i18n key pattern_invalid_name added to all 11 locale files; test cases cover all common traversal variants. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getFromDBjoined user-supplied pattern names directly intofilepath.Joinwith no sanitisation, allowing names like../etc/passwdto escape the patterns directorystrings.Contains(name, "..")guard at the top ofgetFromDBthat returns an error immediatelypattern_invalid_namei18n key to all 11 locale files (English + 10 translations)TestGetFromDB_PathTraversaltest covering 5 traversal variantsCloses #2094.
Test plan
go test ./internal/plugins/db/fsdb/...passes with newTestGetFromDB_PathTraversaltest..) continue to work..anywhere return an error containing "invalid pattern name"🤖 Generated with Claude Code