Security: fix remote file write and shell injection in template extensions#2107
Open
johnpippett wants to merge 2 commits into
Open
Security: fix remote file write and shell injection in template extensions#2107johnpippett wants to merge 2 commits into
johnpippett wants to merge 2 commits into
Conversation
…attern - internal/core/chatter.go: disable auto-application of file changes in API mode (opts.UpdateChan != nil). The REST API accepts PatternName from the JSON body; allowing unsupervised file writes via the API is a remote arbitrary file write vulnerability. - internal/domain/file_manager.go: replace weak strings.Contains(path, "..") defense with proper path containment checks. Reject absolute paths and verify the resolved path is within the project root using filepath.Clean and prefix matching.
Switch from strings.HasPrefix to filepath.Rel for verifying that the resolved target path stays within the project root. This correctly handles edge cases such as a project root of '/' and is more idiomatic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two critical security findings:
Changes are minimal and backward-compatible.