Skip to content

Replace deprecated gRPC dial functions and refactor Makefile#38

Merged
masa213f merged 3 commits intomainfrom
update-20260409
Apr 10, 2026
Merged

Replace deprecated gRPC dial functions and refactor Makefile#38
masa213f merged 3 commits intomainfrom
update-20260409

Conversation

@masa213f
Copy link
Copy Markdown
Contributor

@masa213f masa213f commented Apr 9, 2026 •
edited
Loading

  • Replace grpc.Dial and grpc.DialContext with grpc.NewClient
  • Extract version constants into Makefile.versions
  • Add lint step to CI
  • Minor CI and e2e Makefile cleanups

@masa213f masa213f changed the title update 20260409 Refactor makefile Apr 9, 2026
@masa213f masa213f changed the title Refactor makefile Replace deprecated gRPC dial functions and refactor Makefile Apr 9, 2026
@masa213f masa213f requested a review from zeroalphat April 9, 2026 03:14
zeroalphat
zeroalphat approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 2e948d3 into main Apr 10, 2026
5 checks passed
@masa213f masa213f deleted the update-20260409 branch April 10, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroalphat zeroalphat zeroalphat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@masa213f @zeroalphat @cybozu-neco