Merged
Conversation
masa213f
commented
Mar 27, 2026
| @@ -1,6 +1,5 @@ | |||
| [book] | |||
| language = "en" | |||
| multilingual = false | |||
Contributor
Author
There was a problem hiding this comment.
The book.multilingual field had been removed in mdBook v0.5.0.
It seems this field wasn't being used.
https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#config-changes
rust-lang/mdBook#2775
masa213f
force-pushed
the
update-20260327
branch
from
267fee2 to
1d0400b
Compare
masa213f
commented
Mar 27, 2026
| } | ||
| if paranoid >= 0 { | ||
| t.Skipf("Skip test because perf_event_paranoid is %q", paranoid) | ||
| t.Skipf("Skip test because perf_event_paranoid is %d", paranoid) |
Contributor
Author
There was a problem hiding this comment.
The test was failing, so I fixed it.
https://github.com/cybozu-go/necoperf/actions/runs/23629613706/job/68825920774?pr=35
# github.com/cybozu-go/necoperf/internal/resource
# [github.com/cybozu-go/necoperf/internal/resource]
Error: internal/resource/perf_test.go:28:53: (*testing.common).Skipf format %q has arg paranoid of wrong type int
FAIL github.com/cybozu-go/necoperf/internal/resource [build failed]
github.com/cybozu-go/necoperf/internal/rpc coverage: 0.0% of statements
zeroalphat
reviewed
Mar 30, 2026
masa213f
force-pushed
the
update-20260327
branch
5 times, most recently
from
af95845 to
8afc725
Compare
masa213f
force-pushed
the
update-20260327
branch
from
8afc725 to
609828b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.