Conversation
Contributor
Author
|
Since v1.34.2 is not available for “kindest/node”, we will pin the version to v1.34.0. |
lrf141
commented
Dec 2, 2025
| }) | ||
|
|
||
| return &orig, r.Patch(ctx, patch, client.Apply, &client.PatchOptions{ | ||
| return &orig, r.Apply(ctx, patch, &client.ApplyOptions{ |
Contributor
Author
There was a problem hiding this comment.
client.Apply is deprecated and will fail static checks.
It is now recommended to use r.Apply instead of r.Patch.
As a result, unstructured.Unstructured can no longer be used as an argument, but I decided to convert it to ApplyConfiguration this time.
This implementation is somewhat unclear, so I think generating ApplyConfiguration might be better in the future. However, due to the large scope of impact, I will not do this at this time.
Contributor
Author
There was a problem hiding this comment.
At least with this implementation, the tests pass.
yamatcha
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #841