Skip to content

chore(deps): bump comet#26388

Merged
mattac21 merged 2 commits intomainfrom
ma/bump-comet-v0.39.3
May 5, 2026
Merged

chore(deps): bump comet#26388
mattac21 merged 2 commits intomainfrom
ma/bump-comet-v0.39.3

Conversation

@mattac21
Copy link
Copy Markdown
Contributor

@mattac21 mattac21 commented May 5, 2026

Description

Closes: #XXXX

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 5, 2026

Greptile Summary

This PR promotes github.com/cometbft/cometbft from a pre-release commit-pinned pseudo-version (v0.39.0-rc1.0.20260417162916-9fcf8612cc6c) to the stable tagged release v0.39.3 across all submodules, and removes the corresponding replace directives that were holding the pin.

  • All 16 go.mod files drop the replace github.com/cometbft/cometbft directive and update the direct/indirect requirement to v0.39.3; all paired go.sum files are regenerated with the correct checksums via make tidy-all.
  • tools/cosmovisor was already on v0.39.1 (not v0.39.0), so its bump is v0.39.1 → v0.39.3; its go.sum also sees minor transitive-dep hash updates (lib/pq, mr-tron/base58) as expected artifacts of re-tidying.
  • CHANGELOG.md gains an entry for this bump, though it was placed under ### Features rather than the more appropriate ### Improvements stanza.

Confidence Score: 5/5

Safe to merge — purely a dependency version promotion with no logic changes; all go.sum files are regenerated and replace directives cleanly removed.

The change is mechanical: bump a pre-release commit pin to a stable tag across every submodule, remove the replace directives, and regenerate checksums. No application logic is touched. The only wrinkle is the changelog stanza placement (Features vs Improvements), which has no runtime impact.

No files require special attention beyond the minor changelog stanza placement in CHANGELOG.md.

Important Files Changed

Filename Overview
CHANGELOG.md Changelog entry added but placed under ### Features instead of ### Improvements
go.mod Bumps cometbft from pre-release commit pin to stable v0.39.3 and removes the replace directive
go.sum go.sum updated with correct checksums for cometbft v0.39.3; old pre-release hashes removed
tools/cosmovisor/go.mod Bumped from v0.39.1 to v0.39.3 (was already on a higher base than other modules) and replace directive removed
tools/cosmovisor/go.sum go.sum updated for cometbft v0.39.3; incidental transitive-dep hash changes (lib/pq, mr-tron/base58) are expected artifacts of tidy

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Pre-release pin\ncometbft v0.39.0-rc1.0.20260417162916] -->|replaced by| B[Stable release\ncometbft v0.39.3]
    B --> C[Root go.mod\nremove replace directive]
    B --> D[client/v2\nstore\nsimapp\ntests\n...]
    B --> E[enterprise/poa\nenterprise/group\n...]
    B --> F[tools/cosmovisor\ntools/confix\ntools/systemtests\n...]
    C --> G[make tidy-all\nregenerate all go.sum]
    D --> G
    E --> G
    F --> G
Loading

Reviews (2): Last reviewed commit: "remove comet replace and tidy" | Re-trigger Greptile

Comment thread scripts/go-update-dep-all.sh Outdated
Comment thread go.mod
Comment thread go.mod
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.88%. Comparing base (3ca76ce) to head (32591ca).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #26388   +/-   ##
=======================================
  Coverage   64.87%   64.88%           
=======================================
  Files         890      890           
  Lines       58583    58583           
=======================================
+ Hits        38008    38013    +5     
+ Misses      20575    20570    -5     

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattac21 mattac21 added the backport/v0.54.x Backport PR's to release/v0.54.x branch label May 5, 2026
@mattac21 mattac21 force-pushed the ma/bump-comet-v0.39.3 branch from 2c3dc68 to 50db63c Compare May 5, 2026 17:06
@mattac21
Copy link
Copy Markdown
Contributor Author

mattac21 commented May 5, 2026

@greptile review again

@mattac21 mattac21 added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit e77c24c May 5, 2026
43 checks passed
@mattac21 mattac21 deleted the ma/bump-comet-v0.39.3 branch May 5, 2026 17:43
warpbuild-benchmark-bot Bot added a commit to WarpBuilds/cosmos-sdk that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v0.54.x Backport PR's to release/v0.54.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants