Skip to content

fix: no semantic size limit for denom unit#26013

Open
yihuang wants to merge 4 commits intomainfrom
limit-denom-unit-size
Open

fix: no semantic size limit for denom unit#26013
yihuang wants to merge 4 commits intomainfrom
limit-denom-unit-size

Conversation

@yihuang
Copy link
Copy Markdown
Collaborator

@yihuang yihuang commented Feb 26, 2026

Description

Closes: #26012

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.81%. Comparing base (2fbcc8d) to head (a661e95).
⚠️ Report is 157 commits behind head on main.

Files with missing lines Patch % Lines
x/bank/types/metadata.go 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #26013      +/-   ##
==========================================
- Coverage   59.88%   59.81%   -0.08%     
==========================================
  Files         981      965      -16     
  Lines       65140    64245     -895     
==========================================
- Hits        39011    38427     -584     
+ Misses      26129    25818     -311     
Files with missing lines Coverage Δ
x/bank/types/metadata.go 94.00% <50.00%> (-6.00%) ⬇️

... and 17 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yihuang yihuang changed the title Problem: no semantic size limit for denom unit fix: no semantic size limit for denom unit Feb 26, 2026
Comment thread CHANGELOG.md Outdated
* (baseapp) [#25862](https://github.com/cosmos/cosmos-sdk/pull/25862) Skip running validateBasic for rechecking txs. (Backport of https://github.com/cosmos/cosmos-sdk/pull/20208).
* (blockstm) [25883](https://github.com/cosmos/cosmos-sdk/pull/25883) Re-use decoded tx object in pre-estimates.
* (blockstm) [#25788](https://github.com/cosmos/cosmos-sdk/pull/25788) Only validate transactions that's executed at lease once.
* (x/bank) [#]() No semantic size limit for denom units.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (x/bank) [#]() No semantic size limit for denom units.
* (x/bank) [#26013](https://github.com/cosmos/cosmos-sdk/pull/26013) No semantic size limit for denom units.

Comment thread CHANGELOG.md Outdated
@aljo242
Copy link
Copy Markdown
Contributor

aljo242 commented Feb 26, 2026

@yihuang this is not tested

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@aljo242 aljo242 requested a review from a team as a code owner May 4, 2026 16:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🔒 WARNING: unsigned commits detected

This pull request contains 1 commit(s) without a verified signature.

How to fix:

  1. Set up commit signing (GPG or SSH).
  2. Amend/rebase so every commit in this PR is verified-signed.
  3. Push the updated branch and open a new PR, or ask a maintainer to reopen once fixed.

Docs: https://docs.github.com/authentication/managing-commit-signature-verification

Unsigned commits:

  • c19292e — chore: merge main into limit-denom-unit-size

Copilot AI review requested due to automatic review settings May 4, 2026 16:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: no semantic size limit for denom units

3 participants