fix(collections/indexes): handle iterator close errors in index helpers#25942
Open
songgaoye wants to merge 13 commits intocosmos:mainfrom
Open
fix(collections/indexes): handle iterator close errors in index helpers#25942songgaoye wants to merge 13 commits intocosmos:mainfrom
songgaoye wants to merge 13 commits intocosmos:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25942 +/- ##
==========================================
+ Coverage 64.87% 65.07% +0.19%
==========================================
Files 890 907 +17
Lines 58583 60116 +1533
==========================================
+ Hits 38008 39118 +1110
- Misses 20575 20998 +423
🚀 New features to boost your workflow:
|
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Contributor
Author
|
@aljo242 can you help review it? Thank you! |
aljo242
approved these changes
May 4, 2026
auto-merge was automatically disabled
May 5, 2026 03:04
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, iterator Close() errors were silently ignored in index helper
functions, which could lead to resource leaks (file descriptors, memory).
This change properly captures and returns close errors when no other error
has occurred, following the standard Go pattern for deferred cleanup.
Fixed functions:
Closes: #XXXX