feat(blockstm): cache pre-state to optimize value-based validation#25909
Open
mmsqe wants to merge 16 commits intocosmos:mainfrom
Open
feat(blockstm): cache pre-state to optimize value-based validation#25909mmsqe wants to merge 16 commits intocosmos:mainfrom
mmsqe wants to merge 16 commits intocosmos:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25909 +/- ##
==========================================
+ Coverage 64.83% 64.86% +0.02%
==========================================
Files 874 875 +1
Lines 57601 57634 +33
==========================================
+ Hits 37347 37384 +37
+ Misses 20254 20250 -4
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
@mmsqe conflicts due to file movements sorry 😅 |
mmsqe
force-pushed
the
cache_prestate
branch
2 times, most recently
from
f9cdc06 to
9329e96
Compare
mmsqe
force-pushed
the
cache_prestate
branch
from
be9ebd8 to
6ff42da
Compare
skip cache oversized
Contributor
Greptile SummaryThis PR optimizes BlockSTM execution by caching pre-state storage reads, reducing expensive storage access during validation. The implementation adds a
The refactoring in Benchmark results show substantial improvements:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Transaction reads key] --> B{Check WriteSet}
B -->|Found| C[Return from WriteSet]
B -->|Not found| D[Read from MVMemory]
D --> E{Version valid?}
E -->|Yes| F[Return value from MVMemory]
E -->|No - pre-state read| G{Check preState cache}
G -->|Cache hit| H[Return cached value]
G -->|Cache miss| I[Read from storage]
I --> J{Value size check}
J -->|Byte slice <= 4KB| K[Store in cache]
J -->|Byte slice > 4KB or non-byte| L{Is byte slice?}
L -->|No - any type| K
L -->|Yes - too large| M[Skip caching]
K --> N[Return value]
M --> N
Last reviewed commit: 911a426 |
wire MVMemory view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update: #25777