fix(blockstm): fix CancelAll cancellation with estimate blocks#25893
Open
mmsqe wants to merge 7 commits intocosmos:mainfrom
Open
fix(blockstm): fix CancelAll cancellation with estimate blocks#25893mmsqe wants to merge 7 commits intocosmos:mainfrom
mmsqe wants to merge 7 commits intocosmos:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25893 +/- ##
==========================================
+ Coverage 64.83% 64.87% +0.03%
==========================================
Files 874 874
Lines 57601 57601
==========================================
+ Hits 37347 37367 +20
+ Misses 20254 20234 -20
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
@mmsqe could you add more context here? |
Contributor
|
@mmsqe conflicts due to file movements sorry 😅 |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When tx2 is suspended on an ESTIMATE mark from tx1 and tx1 is not suspended, clearing estimates only for suspended txns won’t help, waking tx2 just makes it suspend again. We need to clear the blocker’s (tx1’s) ESTIMATE mark as well, clear estimates for all txns before/while waking waiters.
Closes: #XXXX