fix(mempool): prevent memory leaks in PriorityNonceMempool Remove#25858
Open
songgaoye wants to merge 13 commits intocosmos:mainfrom
Open
fix(mempool): prevent memory leaks in PriorityNonceMempool Remove#25858songgaoye wants to merge 13 commits intocosmos:mainfrom
songgaoye wants to merge 13 commits intocosmos:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25858 +/- ##
==========================================
- Coverage 64.87% 64.85% -0.03%
==========================================
Files 890 874 -16
Lines 58581 57603 -978
==========================================
- Hits 38006 37358 -648
+ Misses 20575 20245 -330
🚀 New features to boost your workflow:
|
Contributor
|
Can we test this? Is there a bug or behavior failure this is addressing? |
Contributor
Author
|
add unit test Before the fix, removing the last tx for a sender left an empty skip list in |
Contributor
|
@songgaoye lgtm - conflicts |
Contributor
Author
|
update. please take a look at @aljo242 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
clean up empty data structures in the Remove function to prevent memory leaks:
Closes: #XXXX