Skip to content

fix(server): reject overlapping historical gRPC block ranges#25807

Merged
aljo242 merged 11 commits intocosmos:mainfrom
songgaoye:fix_server_overlapping_historical
Jan 29, 2026
Merged

fix(server): reject overlapping historical gRPC block ranges#25807
aljo242 merged 11 commits intocosmos:mainfrom
songgaoye:fix_server_overlapping_historical

Conversation

@songgaoye
Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX

Historical gRPC routing iterates over a map with random iteration order.
Overlapping block ranges cause nondeterministic backend selection across
runs. Added validation in GetConfig to detect and reject overlapping
ranges at parse time with clear error messages.

Comment thread server/config/config.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.24%. Comparing base (7af05f5) to head (17aeed3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25807      +/-   ##
==========================================
+ Coverage   68.16%   68.24%   +0.08%     
==========================================
  Files         910      894      -16     
  Lines       59051    58158     -893     
==========================================
- Hits        40250    39688     -562     
+ Misses      18801    18470     -331     
Files with missing lines Coverage Δ
server/config/config.go 93.68% <100.00%> (+0.58%) ⬆️

... and 18 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242
Copy link
Copy Markdown
Contributor

aljo242 commented Jan 26, 2026

ci failing

@aljo242 aljo242 enabled auto-merge January 29, 2026 19:48
@aljo242 aljo242 added this pull request to the merge queue Jan 29, 2026
Merged via the queue into cosmos:main with commit ebd1f2f Jan 29, 2026
45 checks passed
@songgaoye songgaoye deleted the fix_server_overlapping_historical branch January 30, 2026 01:15
Cordtus pushed a commit to Cordtus/cosmos-sdk that referenced this pull request Feb 3, 2026
…25807)

Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants