Skip to content

feat(telemetry): disk io filters#25805

Merged
technicallyty merged 2 commits intoaaronc/telemetry-disk-iofrom
technicallyty/filter
Jan 21, 2026
Merged

feat(telemetry): disk io filters#25805
technicallyty merged 2 commits intoaaronc/telemetry-disk-iofrom
technicallyty/filter

Conversation

@technicallyty
Copy link
Copy Markdown
Member

Description

adds filters for diskio metrics

@technicallyty technicallyty requested a review from aaronc January 21, 2026 07:45
@github-actions
Copy link
Copy Markdown
Contributor

@technicallyty your pull request is missing a changelog!

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.22%. Comparing base (babde14) to head (a3742d0).

Files with missing lines Patch % Lines
telemetry/util/diskio/diskio.go 0.00% 16 Missing ⚠️
telemetry/util/diskio/options.go 0.00% 4 Missing ⚠️
telemetry/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           aaronc/telemetry-disk-io   #25805      +/-   ##
============================================================
- Coverage                     68.22%   68.22%   -0.01%     
============================================================
  Files                           891      891              
  Lines                         58095    58115      +20     
============================================================
+ Hits                          39636    39649      +13     
- Misses                        18459    18466       +7     
Files with missing lines Coverage Δ
telemetry/config.go 2.35% <0.00%> (ø)
telemetry/util/diskio/options.go 0.00% <0.00%> (ø)
telemetry/util/diskio/diskio.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filter should be enabled by default. Also, how about we create an options struct for disk IO instrumentation in cosmos extra?

How robust do you think these filters are for different system setups?

@technicallyty technicallyty merged commit 5d48e68 into aaronc/telemetry-disk-io Jan 21, 2026
37 of 38 checks passed
@technicallyty technicallyty deleted the technicallyty/filter branch January 21, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants