feat(telemetry): disk io filters#25805
Merged
technicallyty merged 2 commits intoaaronc/telemetry-disk-iofrom Jan 21, 2026
Merged
feat(telemetry): disk io filters#25805technicallyty merged 2 commits intoaaronc/telemetry-disk-iofrom
technicallyty merged 2 commits intoaaronc/telemetry-disk-iofrom
Conversation
Contributor
|
@technicallyty your pull request is missing a changelog! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## aaronc/telemetry-disk-io #25805 +/- ##
============================================================
- Coverage 68.22% 68.22% -0.01%
============================================================
Files 891 891
Lines 58095 58115 +20
============================================================
+ Hits 39636 39649 +13
- Misses 18459 18466 +7
🚀 New features to boost your workflow:
|
aaronc
approved these changes
Jan 21, 2026
Member
aaronc
left a comment
There was a problem hiding this comment.
I think the filter should be enabled by default. Also, how about we create an options struct for disk IO instrumentation in cosmos extra?
How robust do you think these filters are for different system setups?
5d48e68
into
aaronc/telemetry-disk-io
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds filters for diskio metrics