fix(blockstm): wake up suspended executors on cancel #25793
Merged
Eric-Warehime merged 13 commits intocosmos:mainfrom Feb 10, 2026
Merged
fix(blockstm): wake up suspended executors on cancel #25793Eric-Warehime merged 13 commits intocosmos:mainfrom
Eric-Warehime merged 13 commits intocosmos:mainfrom
Conversation
to prevent goroutine leaks and hanging when scheduler doesn't complete
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25793 +/- ##
==========================================
- Coverage 70.84% 68.59% -2.25%
==========================================
Files 890 889 -1
Lines 58024 58017 -7
==========================================
- Hits 41106 39797 -1309
- Misses 16918 18220 +1302
... and 38 files with indirect coverage changes 🚀 New features to boost your workflow:
|
yihuang
reviewed
Jan 19, 2026
mmsqe
commented
Jan 19, 2026
yihuang
reviewed
Jan 19, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+60
to
+69
| go func() { | ||
| select { | ||
| case <-ctx.Done(): | ||
| canceled := scheduler.CancelAll() | ||
| for _, txn := range canceled { | ||
| mvMemory.ClearEstimates(txn) | ||
| } | ||
| case <-cancelDone: | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine
yihuang
reviewed
Jan 21, 2026
yihuang
reviewed
Jan 21, 2026
Eric-Warehime
approved these changes
Feb 10, 2026
warpbuild-benchmark-bot Bot
added a commit
to WarpBuilds/cosmos-sdk
that referenced
this pull request
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
to prevent goroutine leaks and hanging when scheduler doesn't complete
Closes: #25789