fix(test): avoid nil pointer on conflicting swagger port for new node in fraud test#24247
Closed
mmsqe wants to merge 3 commits intocosmos:mainfrom
Closed
fix(test): avoid nil pointer on conflicting swagger port for new node in fraud test#24247mmsqe wants to merge 3 commits intocosmos:mainfrom
mmsqe wants to merge 3 commits intocosmos:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis pull request updates the documentation and configuration for the Swagger server. The comment in the server creation function is revised to clearly state that a Swagger server is created. In addition, the default Swagger port is introduced in the system tests, and the configuration for each node is enhanced by setting its corresponding Swagger endpoint during both full node addition and testnet initialization. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Caller
participant Registry as Fullnode Registry
participant Config as Config Document
Client->>Registry: Call AddFullnode(nodeNumber)
Registry->>Config: SetValue(doc, node.IP:(DefaultSwaggerPort+nodeNumber), "swagger", "address")
Config-->>Registry: Confirmation of updated config
Registry-->>Client: Fullnode added with Swagger endpoint
sequenceDiagram
participant Initializer as TestnetInitializer
participant Config as Config Document
Initializer->>Config: UpdatePort(doc, DefaultSwaggerPort+i, "swagger", "address")
Config-->>Initializer: Port configuration updated
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for more info, https://github.com/cosmos/cosmos-sdk/actions/runs/14170361098/job/39692592132
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit