Skip to content

(fix:setCamera): update clipping plane unless camera move in view plane#2678

Open
bionoone wants to merge 1 commit intocornerstonejs:mainfrom
bionoone:fix/set-camera-mpr-swap-axis
Open

(fix:setCamera): update clipping plane unless camera move in view plane#2678
bionoone wants to merge 1 commit intocornerstonejs:mainfrom
bionoone:fix/set-camera-mpr-swap-axis

Conversation

@bionoone
Copy link
Copy Markdown
Contributor

update clipping plane unless camera move in view plane ( former implementation fails when swapping axis : normal, focal & viewup remain the same )

Context

We are changing view from axial -> coronal -> sagittal
there are transition where viewup remains the same, focal point do not move => clipping plane remains the same
( this is wrong : we rotate 90° in space )

Changes & Results

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 11
  • "Node version: 24.14.0
  • "Browser: Chrome 146.0.7680.165

…lane normal ( former implementation fails when swapping axis : normal, focal & viewup remain the same )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant