Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/isiscore/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23667555453. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23761298741. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@conda-forge-admin, please restart ci |
|
@conda-forge/help-c-cpp This recipe is ready for review |
|
@conda-forge/help-c-cpp This recipe is ready for review |
recipes/isiscore/meta.yaml
Outdated
| - cmake >=3.27,<3.28 | ||
| - ninja >=1.10,<1.11 |
There was a problem hiding this comment.
Hi @traversaro, thanks for the quick review on this. This recipe is reflective of conda-forge before the automatic migration mechanisms were in place, so the restrictive pinning was a solution to prevent dependencies from changing too much rather than release the software every time a dependency updated. We will update the recipe to be more in line with current conda-forge feedstocks
recipes/isiscore/meta.yaml
Outdated
| host: | ||
| - python | ||
| - gdal >=3.12.2,<4 | ||
| - mesalib # [linux] |
There was a problem hiding this comment.
Are you sure you actually need mesalib in host?
recipes/isiscore/meta.yaml
Outdated
| - setuptools | ||
| host: | ||
| - python | ||
| - gdal >=3.12.2,<4 |
There was a problem hiding this comment.
Why such strict pins? This will interefere with the conda-forge ABI migration branch mechamism.
recipes/isiscore/meta.yaml
Outdated
| - libgl-devel # [linux] | ||
| - libgdal-core | ||
| - libvulkan-headers | ||
| - nlohmann_json =3.11.2 |
recipes/isiscore/meta.yaml
Outdated
| - setuptools | ||
| - qt6-main >=6,<7 |
There was a problem hiding this comment.
As the package itself is called qt6-main, probably we can drop the version specifier?
recipes/isiscore/meta.yaml
Outdated
| - swig | ||
| run: | ||
| - python | ||
| - libgdal-core |
There was a problem hiding this comment.
Isn't this already handled by the run_exports?
| @@ -0,0 +1,52 @@ | |||
| {% set version = "10.0.0_RC2" %} | |||
There was a problem hiding this comment.
Can we wait for the actual release? conda-forge has specific policies for pre-releases, see https://conda-forge.org/docs/maintainer/knowledge_base/#pre-release-builds .
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/isiscore/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24362273539. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
126f038 to
c9e6b2b
Compare
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).