Skip to content

Adding isis_core#32769

Open
amystamile-usgs wants to merge 139 commits intoconda-forge:mainfrom
amystamile-usgs:isis_core
Open

Adding isis_core#32769
amystamile-usgs wants to merge 139 commits intoconda-forge:mainfrom
amystamile-usgs:isis_core

Conversation

@amystamile-usgs
Copy link
Copy Markdown
Contributor

@amystamile-usgs amystamile-usgs commented Mar 27, 2026

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Mar 27, 2026

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/isiscore/meta.yaml) and found some lint.

Here's what I've got...

For recipes/isiscore/meta.yaml:

  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23667555453. Examine the logs at this URL for more detail.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/isiscore/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: acpaquette. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/isiscore/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23761298741. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/isiscore/meta.yaml) and found it was in an excellent condition.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@amystamile-usgs
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please restart ci

@amystamile-usgs
Copy link
Copy Markdown
Contributor Author

@conda-forge/help-c-cpp This recipe is ready for review

@amystamile-usgs
Copy link
Copy Markdown
Contributor Author

@conda-forge/help-c-cpp This recipe is ready for review

Comment on lines +19 to +20
- cmake >=3.27,<3.28
- ninja >=1.10,<1.11
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why such strict pins?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @traversaro, thanks for the quick review on this. This recipe is reflective of conda-forge before the automatic migration mechanisms were in place, so the restrictive pinning was a solution to prevent dependencies from changing too much rather than release the software every time a dependency updated. We will update the recipe to be more in line with current conda-forge feedstocks

host:
- python
- gdal >=3.12.2,<4
- mesalib # [linux]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you actually need mesalib in host?

- setuptools
host:
- python
- gdal >=3.12.2,<4
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why such strict pins? This will interefere with the conda-forge ABI migration branch mechamism.

- libgl-devel # [linux]
- libgdal-core
- libvulkan-headers
- nlohmann_json =3.11.2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why such strict pin?

Comment on lines +31 to +32
- setuptools
- qt6-main >=6,<7
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the package itself is called qt6-main, probably we can drop the version specifier?

- swig
run:
- python
- libgdal-core
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already handled by the run_exports?

@@ -0,0 +1,52 @@
{% set version = "10.0.0_RC2" %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wait for the actual release? conda-forge has specific policies for pre-releases, see https://conda-forge.org/docs/maintainer/knowledge_base/#pre-release-builds .

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/isiscore/meta.yaml) and found some lint.

Here's what I've got...

For recipes/isiscore/meta.yaml:

  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24362273539. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/isiscore/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.