Bump ws from 8.18.0 to 8.20.1#4974
Conversation
Bumps [ws](https://github.com/websockets/ws) from 8.18.0 to 8.20.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.0...8.20.1) --- updated-dependencies: - dependency-name: ws dependency-version: 8.20.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR is currently unmergeable due to a non-existent version string for the 'ws' library in package.json, which will cause installation failures and poses a potential security risk (dependency confusion). Additionally, while the main dependency is bumped, the vulnerable version (8.18.0) is introduced as a nested dependency for '@backstage/cli' within the lockfile, meaning the security risk persists. The package-lock.json also contains extensive unrelated platform-specific changes that should be reverted. Codacy reports the PR as 'Up to Standards' at a high level, but the agent-based review identified these logic and security gaps.
About this PR
- The package-lock.json contains substantial unrelated changes, adding numerous platform-specific bindings for
@oxc-resolverand@swc/core. These changes are out of scope for a dependency bump and suggest the lockfile was generated in a different environment. Please revert these to keep the PR focused.
Test suggestions
- Verify that 'websocket.close()' handles TypedArray arguments without disclosing uninitialized memory (Security Regression Test).
- Confirm existing WebSocket functionality (connection, data transfer, heartbeat) remains operational with the new library version.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that 'websocket.close()' handles TypedArray arguments without disclosing uninitialized memory (Security Regression Test).
2. Confirm existing WebSocket functionality (connection, data transfer, heartbeat) remains operational with the new library version.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "webpack": "^5.95.0", | ||
| "webpack-manifest-plugin": "^5.0.0", | ||
| "ws": "^8.18.0", | ||
| "ws": "^8.20.1", |
There was a problem hiding this comment.
🔴 HIGH RISK
The version 8.20.1 for ws is not found on the official npm registry. Using a non-existent version will break builds and could be a security risk. Please verify the latest available version (e.g., via npm view ws versions) and update package.json accordingly.
| } | ||
| }, | ||
| "node_modules/@backstage/cli/node_modules/ws": { | ||
| "version": "8.18.0", |
There was a problem hiding this comment.
🟡 MEDIUM RISK
This change introduces version 8.18.0 as a nested dependency, which is the exact version containing the security vulnerability this PR aims to resolve. Even if only used in dev tools, the vulnerable code remains in the repository dependency tree.
| "node": ">=14" | ||
| } | ||
| }, | ||
| "node_modules/@oxc-resolver/binding-darwin-arm64": { |
There was a problem hiding this comment.
⚪ LOW RISK
Nitpick: This file contains hundreds of unrelated changes for platform-specific bindings of @oxc-resolver and @swc/core. These should be reverted to keep the PR focused. Consider running a clean install in the standard environment.
Bumps ws from 8.18.0 to 8.20.1.
Release notes
Sourced from ws's releases.
... (truncated)
Commits
5d9b316[dist] 8.20.1c0327ec[security] Fix uninitialized memory disclosure inwebsocket.close()ce2a3d6[ci] Test on node 2658e45b8[ci] Do not test on node 255f26c24[ci] Run the lint step on node 248439255[dist] 8.20.0d3503c1[minor] Export thePerMessageDeflateclass and header utils3ee5349[api] Convert theisServerandmaxPayloadparameters to options91707b4[doc] Add missing space8b55319[pkg] Update eslint to version 10.0.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.