Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughUpdated CI workflow and package.json for major version 8.0.0 release with Node.js 20+ support requirement. Added Node.js version compatibility guards in tests to handle breaking changes in Node.js 22+. Updated key dependencies, removed legacy Node versions, and bumped tooling versions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @elrrrrrrr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical maintenance task: updating several key project dependencies to their latest major versions. The most significant update is to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR updates four key dependencies—@npmcli/arborist, node-gyp, pacote, and tar—across multiple major versions. While the update to tar resolves a security vulnerability, the scope of this PR is much larger than what the title, chore(deps): tar@7, suggests. Each of these major version bumps introduces a significant risk of breaking changes that could impact core functionality, from dependency resolution to package extraction. I've added comments on each updated dependency to highlight the potential risks. The PR title and description should be updated to reflect the full scope of these changes.
|
need to release a major version, drop Node.js < 20 support |
790e05f to
80f51c7
Compare
|
我先合并,自动发布等我晚上更新后再执行 https://github.com/cnpm/npminstall/blob/master/.github/workflows/release.yml |
[skip ci] ## 8.0.0 (2026-01-20) * feat: enable auto release (#481) ([8fed5a6](8fed5a6)), closes [#481](#481) [hi#level](https://github.com/hi/issues/level) * feat!: npminstall v8 (#479) ([d213d25](d213d25)), closes [#479](#479) [hi#level](https://github.com/hi/issues/level) ### BREAKING CHANGE * Node.js >= 20 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Modified CI workflow to trigger only on master branch, removing support for legacy branches * Removed automated CodeQL security analysis workflow * Updated release workflow configuration with new NPM release automation
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fix https://github.com/eggjs/egg/security/dependabot/52

Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.