Skip to content

[Snyk] Security upgrade urllib from 3.27.3 to 4.0.0 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atian25 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib from 3.27.3 to 4.0.0 #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"dependencies": {
"chalk": "^2.4.2",
"semver": "^7.3.7",
"urllib": "^3.3.0"
"urllib": "^4.0.0"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This major version upgrade of urllib is marked as a breaking change by Snyk (isBreakingChange:true). The project uses urllib's request API in lib/mirror_config.js and its MockAgent API in test/index.test.js. Major version upgrades often alter APIs, so the existing code is unlikely to work correctly with [email protected] without modifications. This will likely cause test failures or runtime errors.

},
"devDependencies": {
"oxlint": "^1.24.0"
Expand Down